staticaddr: channel funding with deposits #937
Conversation
hieblmi
force-pushed
the
static-open-channel
branch
2 times, most recently
from
60286d0 to
97049c1
Compare
hieblmi
force-pushed
the
static-open-channel
branch
6 times, most recently
from
6c330e5 to
4184f2d
Compare
hieblmi
changed the title
hieblmi
force-pushed
the
static-open-channel
branch
4 times, most recently
from
fbe14d2 to
59975f0
Compare
|
Rebased |
hieblmi
force-pushed
the
static-open-channel
branch
from
59975f0 to
596b1df
Compare
|
Rebased |
hieblmi
force-pushed
the
static-open-channel
branch
from
596b1df to
4d0e787
Compare
|
Rebased master |
hieblmi
force-pushed
the
static-open-channel
branch
from
4d0e787 to
818b915
Compare
|
Rebased master. |
hieblmi
force-pushed
the
static-open-channel
branch
from
818b915 to
c4dc989
Compare
hieblmi
force-pushed
the
static-open-channel
branch
2 times, most recently
from
bf7bd29 to
7bd2fd0
Compare
|
Rebased with latest master |
| @@ -0,0 +1,134 @@ | |||
| package staticutil | |||
There was a problem hiding this comment.
Non-ascii characters in the commit message. I think we can remove it.
| ) | ||
|
|
||
| // ToPrevOuts converts a slice of deposits to a map of outpoints to TxOuts. | ||
| func ToPrevOuts(deposits []*deposit.Deposit, |
There was a problem hiding this comment.
I propose to cover the function with unit tests.
| ) | ||
| } | ||
|
|
||
| func (m *Manager) toPrevOuts(deposits []*deposit.Deposit, |
There was a problem hiding this comment.
Shouldn't this method reuse staticutil.ToPrevOuts?
Also we have loopin.StaticAddressLoopIn.toPrevOuts method. I guess it should also reuse staticutil.ToPrevOuts, right?
| signer lndclient.SignerClient, deposits []*deposit.Deposit, | ||
| addrParams *address.Parameters, | ||
| staticAddress *script.StaticAddress) ([]*input.MuSig2SessionInfo, | ||
| [][]byte, error) { |
There was a problem hiding this comment.
I propose to cover the function with unit tests.
| } | ||
|
|
||
| // CreateMusig2Sessions creates a musig2 session for a number of deposits. | ||
| func CreateMusig2Sessions(ctx context.Context, |
There was a problem hiding this comment.
Can we reuse this function in loopin.StaticAddressLoopIn.createMusig2Sessions?
| returns (StaticAddressSummaryResponse); | ||
|
|
||
| /* loop:`static` | ||
| /* loop:`in` |
| rpc StaticAddressLoopIn (StaticAddressLoopInRequest) | ||
| returns (StaticAddressLoopInResponse); | ||
|
|
||
| /* loop:`openchannel` |
| /* | ||
| An optional error string. | ||
| */ | ||
| string error = 2; |
There was a problem hiding this comment.
Can't we deliver errors via gRPC errors?
| uint64 asset_cost_offchain = 3; | ||
| } | ||
|
|
||
| message OpenChannelRequest { |
There was a problem hiding this comment.
PTAL at hieblmi#2
I removed all the code below this line from this file and used the original LND types from lntypes.
� Conflicts: � staticaddr/utils.go
hieblmi
force-pushed
the
static-open-channel
branch
from
a0fe637 to
706c1ff
Compare
2 participants
This PR introduces a
openchannelsubcommand to static addresses.It provides the same experience as
lncli openchannel.Exmples:
Open a channel with all available deposits:
Open a channel with specified local funding amount, coin-selected from available deposits under fee and dust considerations.
Open a channel from two deposits AAA and BBB while taking their combined value(fundmax) as funding amount and considering fees and dust limit.
Open a channel from two deposits AAA and BBB while taking a specified amount(local_amt) as funding amount and considering fees and dust limit.
TODOs: